Skip to content

update package license string to be spdx compatible #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

altendky
Copy link
Contributor

Using https://github.com/actions/dependency-review-action in https://github.com/Chia-Network/chia_rs/actions/runs/11807687782/job/32894842447?pr=785 I got an error stating that the existing license short text MIT/Apache-2.0/NCSA is invalid from an SPDX perspective.

Licenses
  Warning: 
  The validity of the licenses of the dependencies below could not be determined. Ensure that they are valid SPDX licenses:
  Cargo.lock » [email protected] – License: MIT/Apache-2.0/NCSA
  Error: Dependency review could not detect the validity of all licenses.

There was discussion with respect to Rust at rust-lang/cargo#2174 (comment) and there are SPDX examples at https://spdx.dev/learn/handling-license-info/.

@Manishearth
Copy link
Member

Ugh, yeah. The old license was not clear, either, but I can confirm that (MIT OR Apache) AND NCSA is correct, and it matches what this crate has said in its readme for ages (The libfuzzer code is NCSA, everything else is MIT OR Apache as is standard for Rust)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants