Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mmaps: fields coverage #243

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

mmaps: fields coverage #243

wants to merge 4 commits into from

Conversation

burrbull
Copy link
Member

cc @adamgreig
What do you think about this?

@adamgreig
Copy link
Member

It would be useful in reviewing PRs to see changes in field coverage, but I don't know if it should put another line of output on the mmap command. Maybe it could be its own coverage command, or maybe it could output field coverage per-register and per-peripheral at the end of their existing lines?

0x10000000 A PERIPHERAL PeriphA (2/3 fields covered)
0x10000010 B  REGISTER REG1: Register A1 (2/2 fields covered)

@burrbull
Copy link
Member Author

burrbull commented Aug 12, 2024

Maybe it could be its own coverage command

This was my initial idea but then I understood there is not real advantage.

maybe it could output field coverage per-register and per-peripheral at the end of their existing lines

per-peripheral should be enough for me.
Per-register entries cause ultra big diffs as for me and hide more valuable changes and fixes.
Also it makes sense to have shorthand for full or zero coverage (or both) to make mmaps cleaner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants