Skip to content

Bump async dependencies #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 24, 2021
Merged

Bump async dependencies #69

merged 4 commits into from
Sep 24, 2021

Conversation

oll3
Copy link
Contributor

@oll3 oll3 commented Sep 22, 2021

Bumped tokio, mio and futures to recent versions. Took some inspiration from the previous gpio-cdev tokio work and also picked some parts from #60.

Not tested the mio parts but the tokio example (from #60) seems to be working.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nastevens (or someone else) soon.

Please see the contribution instructions for more information.

@oll3 oll3 mentioned this pull request Sep 22, 2021
@oll3 oll3 changed the title Bump async depdendencies Bump async dependencies Sep 22, 2021
@eldruin
Copy link
Member

eldruin commented Sep 23, 2021

Thank you very much!
CI failed now just because of an unused import.
Could somebody else review this @rust-embedded/embedded-linux?
Maybe @ryankurte?

@oll3
Copy link
Contributor Author

oll3 commented Sep 23, 2021

CI failed now just because of an unused import.

Fixed the unused import (and squashed it to the previous commit).

oll3 and others added 2 commits September 23, 2021 09:53
Bump tokio to version 1.x, mio to 0.7.x and futures to 0.3.
Also set edition to 2018.
@oll3
Copy link
Contributor Author

oll3 commented Sep 23, 2021

CI failed now just because of an unused import.

Fixed the unused import (and squashed it to the previous commit).

...and another fix for the mio-evented feature added 👀

Copy link
Member

@posborne posborne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, I think the only thing I would like to see updated is to bump the version in Cargo.toml and look to identify the new MSRV as I suspect these changes impact the minimum supported rust version.

@oll3
Copy link
Contributor Author

oll3 commented Sep 24, 2021

Changes LGTM, I think the only thing I would like to see updated is to bump the version in Cargo.toml and look to identify the new MSRV as I suspect these changes impact the minimum supported rust version.

Tokio has MSVR at 1.45 and rust-sysfs-gpio says 1.46 in README.md so it's probably fine as it is.
Should bumping of crate version be in this PR, 0.6.0?

Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
I have a couple of details left to do before the release so I would do the version bump in a separate PR.
@oll3 could you also add an entry about these updates to the changelog?
Then I would merge this.

Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work!
bors r+

bors bot added a commit that referenced this pull request Sep 24, 2021
69: Bump async dependencies r=eldruin a=oll3

Bumped tokio, mio and futures to recent versions. Took some inspiration from the previous gpio-cdev tokio work and also picked some parts from #60.

Not tested the mio parts but the tokio example (from #60) seems to be working.

Co-authored-by: Olle Sandberg <[email protected]>
Co-authored-by: Paul Osborne <[email protected]>
@eldruin eldruin merged commit 0296e8e into rust-embedded:master Sep 24, 2021
@eldruin eldruin mentioned this pull request Sep 24, 2021
@bors
Copy link
Contributor

bors bot commented Sep 24, 2021

Timed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants