-
Notifications
You must be signed in to change notification settings - Fork 44
Bump async dependencies #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nastevens (or someone else) soon. Please see the contribution instructions for more information. |
Thank you very much! |
Fixed the unused import (and squashed it to the previous commit). |
Bump tokio to version 1.x, mio to 0.7.x and futures to 0.3. Also set edition to 2018.
Signed-off-by: Paul Osborne <[email protected]>
...and another fix for the mio-evented feature added 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, I think the only thing I would like to see updated is to bump the version in Cargo.toml and look to identify the new MSRV as I suspect these changes impact the minimum supported rust version.
Tokio has MSVR at 1.45 and rust-sysfs-gpio says 1.46 in README.md so it's probably fine as it is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
I have a couple of details left to do before the release so I would do the version bump in a separate PR.
@oll3 could you also add an entry about these updates to the changelog?
Then I would merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work!
bors r+
69: Bump async dependencies r=eldruin a=oll3 Bumped tokio, mio and futures to recent versions. Took some inspiration from the previous gpio-cdev tokio work and also picked some parts from #60. Not tested the mio parts but the tokio example (from #60) seems to be working. Co-authored-by: Olle Sandberg <[email protected]> Co-authored-by: Paul Osborne <[email protected]>
Timed out. |
Bumped tokio, mio and futures to recent versions. Took some inspiration from the previous gpio-cdev tokio work and also picked some parts from #60.
Not tested the mio parts but the tokio example (from #60) seems to be working.