Fix use in multi-config builds that don't target glibc #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building for a BeaglePlay with meta-ti yields a multi-config build,
where some of the images built are for the regular (glibc) based Linux,
and some images are for bare-metal environment.
In that bare-metal environment, TARGET_OS is set to "eabi":
meta/conf/distro/include/tclibc-baremetal.inc:TARGET_OS:arm = "eabi"
This makes meta-rust-bin abort fatally.
This patch proposes a more graceful handling by skipping such recipes,
instead of aborting the entire build, including the images where
TARGET_OS is set to Linux. This also appears to be inline with how other
recipes in oe-core handle this.
|
Whoops, I see this duplicates #202 and ends up with exactly the same change by accident :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building for a BeaglePlay with meta-ti yields a multi-config build, where some of the images built are for the regular (glibc) based Linux, and some images are for bare-metal environment.
In that bare-metal environment, TARGET_OS is set to "eabi":
This makes meta-rust-bin abort fatally.
This patch proposes a more graceful handling by skipping such recipes, instead of aborting the entire build, including the images where TARGET_OS is set to Linux. This also appears to be inline with how other recipes in oe-core handle this.