Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propose report feature #147

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

terakilobyte
Copy link

related to #54

Perhaps not the best name, but my proposal to allow specifying what to do with the report itself. The original text will show if not specified so it shouldn't introduce a regression.

@epage
Copy link
Collaborator

epage commented Jul 22, 2024

I was hoping to discuss a wording tweak only at this point. I'd like discussion of a report to be discussed and decided in its own issue. Wording tweaks are much easier to decide on than changes that increase the API compatibility we have to maintain.

@terakilobyte
Copy link
Author

I can respect that. For our particular use, we're spelling out what to do with support and it goes against what the current wording is. I realize that may not be everyone's use.

I can close this (or you can), or open a new issue and reference it instead. Your choice!

@epage
Copy link
Collaborator

epage commented Jul 23, 2024

If your up for limiting this to just the wording change, that'd work

@terakilobyte
Copy link
Author

Yes, I can do that. I'll also open another issue about customizing the report output. Maybe I'll leave this and reference that new issue, and open a new PR just for the wording change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants