-
Notifications
You must be signed in to change notification settings - Fork 64
add basic_toml_conf
feature
#112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
maybe as non-default feature? |
does this look good, or should I fork? |
toml
to basic-toml
basic_toml_conf
feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I would be okay adding this in, do you have any metrics for what this move would save the average developer (compile times, binary size, etc)?
I don't think I have ever reached for basic_toml
over toml
before. I can also talk to @epage to see if toml-rs
would be interested in taking in basic_toml
since it was very recently unmaintained.
In abstracting the use of
Keep in mind dtolnay created With those caveats, I would personally think it questioable to support but then again, I maintain the name of the crate it was forked from (it was forked from
I have no interest in maintaining it. Part of my condition for taking on maintaining I am playing with a new parser implementation for |
thanks for the info, I understand this as for the refactors and docs, I’ll look into them next week as they’re reasonable |
add feature to migrate from the massive
toml
dependency to it's light-weight hard fork (now unmaintained, but functional)basic-toml
. AFAIK it supports most toml syntax, except for date-time