fix: Add key tracking for all error types #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like we lose track of `origin` in a lot of cases when merging sources which makes actual `origin` tracking meaningless until that is fixed which looked non-trivial. Adding this field at least gives us more of an option to do it later.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
epage
force-pushed
the
key
branch
2 times, most recently
from
30866fb to
7496699
Compare
Pull Request Test Coverage Report for Build 12713265800Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already track
keyfor invalid type errors and this extends it to all other error types.I created
ConfigError::Atvariant to avoid breaking changes. We can revisit that design when making a breaking change.Closes #632