Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(path): Switch from recursive to iterative structures #622

Merged
merged 16 commits into from
Dec 19, 2024
Merged

refactor(path): Switch from recursive to iterative structures #622

merged 16 commits into from
Dec 19, 2024

Conversation

epage
Copy link
Contributor

@epage epage commented Dec 19, 2024

Likely some minor fixes on the way.

Hopefully I didn't miss a case and break people...

epage added 16 commits December 19, 2024 09:59
@epage
test(path): Switch to snapbox
4134a95
@epage
refactor(path): Avoid Expression implementation details
c855e4f
@epage
fix(set): Correctly handle negative indices on non-leaf
6abd1c9
@epage
refactor(path): Clarify a case is unreachable
d3dd1bb
@epage
refactor(path): Explicitly mark unreachable branches
aa3922c
@epage
refactor(path): Be consistent in overriding entries
dcb17d0
@epage
refactor(path): Consistently use and if
4e1afb0 
Less nesting
@epage
refactor(path): Don't duplicate lookup logic
2193da2
@epage
fix(path): Ensure we always postfix
5844d41
@epage
refactor(path): Remove unused Option
3b46d76
@epage
refactor(path): Consolidate table checks
8b074cb
@epage
refactor(path): Fully delegate lookup to get_mut_forcibly
ec36bff
@epage
refactor(path): Make lookups more consistent
02e62db
@epage
refactor(path): Make names more consistent
8323fa2
@epage
refactor(path): Flatten with let-else
c397a10
@epage
refactor(path): Switch from recursive to iterative structures
80ca240
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12419432224

Details

  • 55 of 59 (93.22%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 63.793%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/path/mod.rs 49 53 92.45%
Totals Coverage Status
Change from base Build 12416090917: -0.1%
Covered Lines: 925
Relevant Lines: 1450
💛 - Coveralls

@epage epage merged commit b509e7e into rust-cli:main Dec 19, 2024
15 checks passed
@epage epage deleted the path branch December 19, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@epage @coveralls