Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using this library, I end up having lifetime issues with
Config::get
. I've seen that current implementation forces the callerto match
key
lifetime to the output of the function.My use case is, under some circumstances, return a suffixed version of
the config key. Something similar to:
This code is not compiling for me due to conflicting lifetimes. To avoid
this, I've started looking to the code and I've found that
key
neededthis lifetime because of
ValueWithKey
. The purpose of this structseems to be add more information to the errors that are returned to the
user.
To mitigate this lifetime coupling I've:
Config::get
to include the originating key ofthe current error
ValueWithKey