Add Descriptor::iter_pk
#823
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit was -not- AI-generated, though probably it should've been.
apoelstra
force-pushed
the
push-slnpvpouumpw
branch
2 times, most recently
from
d3fab75 to
82f86e1
Compare
This one -was- AI-generated, though I reviewed it.
apoelstra
force-pushed
the
push-slnpvpouumpw
branch
from
82f86e1 to
aa42cd3
Compare
sanket1729
reviewed
May 27, 2025
| use crate::{miniscript, Miniscript, MiniscriptKey}; | ||
|
|
||
| /// Iterator over all the keys in a descriptor. | ||
| pub struct PkIter<'desc, Pk: MiniscriptKey> { |
There was a problem hiding this comment.
This is fine. But Ideally, we want this to be a sum type instead of a product type? But then we get whole loads of matches everywhere?
There was a problem hiding this comment.
The main reason to use a product type was that Taproot descriptors have both single keys and (optionally) a taptree iterator.
And in PkIter::next I have a construction where the taptree iterator yields new Miniscript pkiters.
I can try to refactor this to use a sum type but I think it would result in more repeated/redundant code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #821.
Should backport to 12.x.