Rewrite (non-compiler) benchmarks #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By having everything in one file it reduces clutter in the codebase, will make it easier to unify benchmark-generation code, and (IMO most importantly) lets you write `cargo bench benchmarks` and then it'll only run the benchmarks instead of outputting a gazillion "ignored" lines telling you that it's not benchmarking random shit that aren't benchmarks. Don't re-format stuff so it'll be obvious in the diff that this is a pure code move. Also we are going to rewrite the benchmarks in the next commit anyway.
This commit doesn't redo the compiler benchmarks because they are not essential to the changes I am planning to make.
sanket1729
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a much larger and more comprehensive set of benchmarks for parsing miniscripts. It now covers:
This doesn't touch the compiler benchmarks, mainly because it seemed like a bunch of work and I don't have any immediate intentions of messing with the compiler. But also because I'm not sure how to approach these -- with the parser I can just do giant trees of pk()s but with the compiler I probably want to use all of pk/hash/timelock etc.