Improve the manifest #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
07-27-manifest
branch
from
817f317 to
f5e317e
Compare
tcharding
force-pushed
the
07-27-manifest
branch
from
f5e317e to
ee91b6f
Compare
In preparation for attempting to stabilise this library add "the rust-bitcoin developers" to the authors. This is both for attribution and to accept responsibility if we do anything wrong.
Add a `documentation` field to the `package` section of the manifest pointing to `https://docs.rs/bech32`.
tcharding
force-pushed
the
07-27-manifest
branch
from
ee91b6f to
b8a448f
Compare
|
Rebase only, no other changes. |
|
Gentle bump, can I get a review please crew. |
|
Gentle bump, you are the merge slave on this repo now @apoelstra - please ACK/NACK and merge if ack'd. To save spamming you please also consider: #71 is a bit more involved but not super hard to review. |
|
For sure! Testing now. This repo is a guinea pig for my new nix-based local CI system (where I work locally and use nix to farm build jobs out to my server rather than working directly on the server and building with hacked-up homebrew Python scripts). So things are a little slow this week as I tune that and start using it on other repos. |
apoelstra
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for attempting to stabilize this crate, do a couple of improvements to the manifest.
packagesection of the manifest, both for attribution and to accept responsibility for mistakes.documentationfield to thepackagesection of the manifest