Finish off updating docs and verify infrastructure #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`node` cannot be built without enabling some features. In preparation for including the `node` crate in the workspace fix the update lock files script to use `--all-features`.
The comments are stale, fix them to correctly explain how the features work in this crate.
Add a `TODO` to the integration test crate commenting that we are not testing the `warnings` field in `CreateWallet`. Bit sloppy but we have an issue already about test coverage not checking optional fields.
tcharding
changed the title
Run `just fmt`. No other manual changes.
Update the `types::v26` rustdocs (the SSOT for the status of v26 support). Add `Version::V26` to the `verify` crate. Verify with `verify v26`.
The `VERSIONS` const is an array that is supposed to include all supported versions but I forgot to update it as I added support to the tool for newer versions. FTR the const is used in the output of `verify v99` (i.e. unsupported version) and also in `verify all`.
Update the `types::v27` rustdocs (the SSOT for the status of v27 support). Add `Version::V27` to the `verify` crate. Verify with `verify v27`.
Update the `types::v28` rustdocs (the SSOT for the status of v28 support). Add `Version::V28` to the `verify` crate. Verify with `verify v28`.
tcharding
force-pushed
the
02-13-verify
branch
from
f2e59f7 to
e32e31f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as #55 but for the last 3 versions (v26, v27, v28) - once this merges all
typesversion specific module rustdocs correctly document the status of the repository - BOOM!As with #55 I'm not expecting review, this will be a whole ton of LOC and reviewing it is unrealistic. Its basically just docs and re-exports. Any mistakes should be caught by the
verifytool - that is its purpose.