Implement pruneblock method and test #132
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GideonBature
force-pushed
the
pruneblockchain
branch
from
26e01dc to
371f56c
Compare
GideonBature
force-pushed
the
pruneblockchain
branch
from
371f56c to
2d05895
Compare
tcharding
reviewed
Apr 28, 2025
| self.call("pruneblockchain", &[target.into()]) | ||
| } | ||
| } | ||
| }; |
There was a problem hiding this comment.
This is good but can be put it after impl_client_v17__preciousblock? I've tried to keep all the files using the same order for methods that they appear in the help output i.e., types/src/v17/mod.rs (or the rpc-api-v17.txt file).
| @@ -49,6 +49,7 @@ crate::impl_client_v17__gettxoutproof!(); | |||
| crate::impl_client_v17__gettxoutsetinfo!(); | |||
| crate::impl_client_v17__preciousblock!(); | |||
| crate::impl_client_v17__verifytxoutproof!(); | |||
| crate::impl_client_v17__pruneblockchain!(); | |||
There was a problem hiding this comment.
Same thing here, please keep the calls in order.
Comment on lines
-26
to
+27
| let json: GetBlockVerboseZero = node.client.get_block_verbose_zero(block_hash).expect("getblock verbose=0"); | ||
| let json: GetBlockVerboseZero = | ||
| node.client.get_block_verbose_zero(block_hash).expect("getblock verbose=0"); |
There was a problem hiding this comment.
These look like unrelated formatting changes. Best not to have these.
| use node::vtype::*; // All the version specific types. | ||
| use node::vtype::*; // All the version specific types. |
There was a problem hiding this comment.
Unrelated change. Looks like we have our editors configured differently. This is the default spacing set by my editor. Neither is right or wrong its just that this is an unrelated whitespace change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going by the conversations with @tcharding for PR #116 on implementing one method at a time for easier review: This is the first method implementation
pruneblockchainwhich is a specific type that returns a standard type (numeric). Once this is approved, I’ll proceed with the remaining ones.