Skip to content

Merge pull request #96 from rust-bio/release-please--branches--master… #43

Merge pull request #96 from rust-bio/release-please--branches--master…

Merge pull request #96 from rust-bio/release-please--branches--master… #43

Triggered via push July 12, 2024 08:46
Status Success
Total duration 47s
Artifacts
release-please
40s
release-please
Fit to window
Zoom out
Zoom in

Annotations

16 warnings
dereferencing a tuple pattern where every element takes a reference: src/strand.rs#L296
warning: dereferencing a tuple pattern where every element takes a reference --> src/strand.rs:296:36 | 296 | (&Option::Some(ref x), &Option::Some(ref x1)) => x.same(x1), | ^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference help: try removing the `&` and `ref` parts | 296 - (&Option::Some(ref x), &Option::Some(ref x1)) => x.same(x1), 296 + (&Option::Some(ref x), Option::Some(x1)) => x.same(x1), |
dereferencing a tuple pattern where every element takes a reference: src/strand.rs#L296
warning: dereferencing a tuple pattern where every element takes a reference --> src/strand.rs:296:14 | 296 | (&Option::Some(ref x), &Option::Some(ref x1)) => x.same(x1), | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference = note: `#[warn(clippy::needless_borrowed_reference)]` on by default help: try removing the `&` and `ref` parts | 296 - (&Option::Some(ref x), &Option::Some(ref x1)) => x.same(x1), 296 + (Option::Some(x), &Option::Some(ref x1)) => x.same(x1), |
this `impl` can be derived: src/sequence.rs#L61
warning: this `impl` can be derived --> src/sequence.rs:61:1 | 61 | / impl Default for SequenceReadPairOrientation { 62 | | fn default() -> Self { 63 | | None 64 | | } 65 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls = help: remove the manual implementation... help: ...and instead derive it... | 49 + #[derive(Default)] 50 | pub enum SequenceReadPairOrientation { | help: ...and mark the default variant | 58 ~ #[default] 59 ~ None, |
non-canonical implementation of `partial_cmp` on an `Ord` type: src/genome.rs#L32
warning: non-canonical implementation of `partial_cmp` on an `Ord` type --> src/genome.rs:32:1 | 32 | / impl PartialOrd for Interval { 33 | | fn partial_cmp(&self, other: &Self) -> Option<cmp::Ordering> { | | __________________________________________________________________- 34 | || Some(self.contig.cmp(&other.contig).then_with(|| { 35 | || self.range 36 | || .start ... || 39 | || })) 40 | || } | ||_____- help: change this to: `{ Some(std::cmp::Ord::cmp(self, other)) }` 41 | | } | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default
this pattern creates a reference to a reference: src/annot/refids.rs#L70
warning: this pattern creates a reference to a reference --> src/annot/refids.rs:70:25 | 70 | if let Some(ref r) = self.refids.get(id) { | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default help: try | 70 ~ if let Some(r) = self.refids.get(id) { 71 ~ r.clone() |
this `impl` can be derived: src/alignment.rs#L52
warning: this `impl` can be derived --> src/alignment.rs:52:1 | 52 | / impl Default for AlignmentMode { 53 | | fn default() -> Self { 54 | | AlignmentMode::Global 55 | | } 56 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls = note: `#[warn(clippy::derivable_impls)]` on by default = help: remove the manual implementation... help: ...and instead derive it... | 45 + #[derive(Default)] 46 | pub enum AlignmentMode { | help: ...and mark the default variant | 48 ~ #[default] 49 ~ Global, |
release-please
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, Swatinem/[email protected], actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
release-please
The following actions uses Node.js version which is deprecated and will be forced to run on node20: google-github-actions/release-please-action@v3, actions/checkout@v2, actions-rs/toolchain@v1, Swatinem/[email protected], actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
release-please
only one of `license` or `license-file` is necessary
release-please
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
release-please
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
release-please
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
release-please
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
release-please
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
release-please
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
release-please
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/