Minimal change for unbounded ranges #17
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15
This is what I believe to be the minimal diff to support right-unbounded ranges with
TextSize
/TextRange
.TextSize(u32::MAX)
is reserved to mean ∞/unbounded, and the only functions that outright need to be adjusted to respect those semantics arechecked_add
(just replaced withsaturating_add
for now),len
(returnTextSize::INF
for unbounded ranges), and the actual indexing.This added semantics to
TextSize
does make the following impls questionable, and deserving of a new fresh look:From<u32> for TextSize
:u32::MAX
is lossyFrom<TextSize> for u32
:TextSize::INF
is lossyTryFrom<usize> for TextSize
:u32::MAX
is lossyFrom<TextSize> for u32
:TextSize::INF
is lossy