Skip to content

update memoffset version #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2023
Merged

Conversation

trickster
Copy link
Contributor

@lnicola
Copy link
Member

lnicola commented May 30, 2023

Can you also bump the version to 0.15.12?

@est31
Copy link

est31 commented Jun 2, 2023

(coming from the rust-lang issue) @trickster did you run tests with --features memoffset/unstable_offset_of enabled? What is the output?

@trickster
Copy link
Contributor Author

@est31

This is the output.

cargo +nightly test --features=memoffset/unstable_offset_of --all

running 3 tests
test green::tests::assert_send_sync ... ok
test green::tests::test_size_of ... ok
test syntax_text::tests::test_text_equality ... ok

test result: ok. 3 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/tidy.rs (/Users/siva/rust-target/debug/deps/tidy-071579816caf0f4a)

running 1 test
test check_code_formatting ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.81s

     Running unittests src/main.rs (/Users/siva/rust-target/debug/deps/xtask-f7dfc96464a1433a)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/tidy.rs (/Users/siva/rust-target/debug/deps/tidy-a0b606e5416fb32e)

running 1 test
test test_formatting ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.42s

   Doc-tests rowan

running 1 test
test src/green/builder.rs - green::builder::GreenNodeBuilder<'_>::checkpoint (line 63) ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.42s

@est31
Copy link

est31 commented Jun 2, 2023

@trickster thanks for verifying it works. I'll check the box in the issue.

@Veykril Veykril merged commit 1d0b674 into rust-analyzer:master Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants