Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Manifest support according to the W3 standard #84

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

austdev
Copy link

@austdev austdev commented Oct 27, 2022

Add new methods for working with Manifest extension:

func (ctx *SigningContext) CreateSignature(id string) *etree.Element
func (ctx *SigningContext) AddManifestRef(sig *etree.Element, name string, hash_id crypto.Hash, digest []byte) error
func (ctx *SigningContext) SignManifest(sig *etree.Element) (*etree.Element, error)

func (ctx *ValidationContext) ValidateManifest(sig *etree.Element) (*types.Manifest, error)
func (ctx *ValidationContext) VerifyReference(ref *types.Reference, data []byte) error
func (ctx *ValidationContext) DecodeRef(ref *types.Reference) (crypto.Hash, []byte, error)

An original API is preserved

@russellhaering
Copy link
Owner

Sorry for the silence on this, it’s next on my list for review.

@austdev
Copy link
Author

austdev commented Mar 8, 2023

It's Ok. I tried to resolve conflicts quickly, but result was broken with some compiler errors. So, I need more time for this. Probably, would it be better to split this request on smaller parts? Or exclude some commits? Please, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants