Some usability improvements to s2example #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps you understand what went wrong.
One of the fields on the Okta test page is Issuer, and the default value doesn't match the Entity ID in their metadata. You have to change it for the demo to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for great library! I was using s2example and a couple issues arose. First, when something went wrong no error was printed (I just got a blank page). Second, the default value for "Issuer" on the Okta Test IdP login page doesn't match the value expected by s2example. This pull requests adds error messages, and prints out the expected Issuer value so you know what to enter on the Okta page.