Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix side_function on K Match on GDB #741

Merged
merged 6 commits into from
Apr 27, 2023
Merged

Fix side_function on K Match on GDB #741

merged 6 commits into from
Apr 27, 2023

Conversation

Robertorosmaninho
Copy link
Collaborator

Fixes: #718

@Robertorosmaninho Robertorosmaninho added the bug Something isn't working label Apr 17, 2023
@Robertorosmaninho Robertorosmaninho self-assigned this Apr 17, 2023
@Robertorosmaninho Robertorosmaninho changed the title Fix K Match on GDB Fix side function on K Match on GDB Apr 20, 2023
@Robertorosmaninho Robertorosmaninho changed the title Fix side function on K Match on GDB Fix side_function on K Match on GDB Apr 20, 2023
@Robertorosmaninho Robertorosmaninho marked this pull request as ready for review April 20, 2023 20:18
dwightguth
dwightguth reviewed Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@dwightguth dwightguth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good but let's define the not equals in c++ also so we can just delete the entire equality.ll file.

@Baltoli
Copy link
Contributor

Baltoli commented Apr 27, 2023

Looks good to me as Dwight and Maria's comments have been addressed.

@rv-jenkins rv-jenkins merged commit 704f3fc into master Apr 27, 2023
@rv-jenkins rv-jenkins deleted the fix-issue-718 branch April 27, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baltoli Baltoli Baltoli approved these changes

@mariaKt mariaKt Awaiting requested review from mariaKt

@dwightguth dwightguth Awaiting requested review from dwightguth

Assignees

@Robertorosmaninho Robertorosmaninho

Labels
automerge bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[GDB] Can't find side_condition_ function globally
4 participants
@Robertorosmaninho @Baltoli @dwightguth @rv-jenkins