Callbacks: Fix side-condition events when arity is non-null #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks as a legitimate bug fix to me. However I expect tests to fail with this fix because we would need to update their reference output. I will start the ci and let’s see what we get. |
theo25
approved these changes
Jan 10, 2025
|
Thank you! |
automergerpr-permission-manager
bot
merged commit af29ee5
into
runtimeverification:develop
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in calls to calls to
side_condition_event_callback. Every time such a call should occur, therewrite_event_callbackis invoked instead.This is due to a bug in the method that builds substitutions, and calls a callback once the substitution has the required size. Instead of conditionally calling either the rewrite callback or the sidecondition callback, it always calls the rewrite one.
This PR fixes the bug.