Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add no-stack-checks to kontrol.toml file #867

Merged
merged 5 commits into from
Oct 16, 2024
Merged

Conversation

anvacaru
Copy link
Contributor

@anvacaru anvacaru commented Oct 15, 2024

Add the --no-stack-checks option to the toml file generated when a new project is created.

Additionally, this PR inverses the dest for the flags starting with --no-... with the dest also starting with no_..., such as

  • --no-metadata, which is now used to set metadata (instead of no_metadata)
  • --no-silence-warnings
  • --no-forge-build
  • --no-stack-checks

The logic of this flag processing is changed accordingly.

The reason for this changes is due to the way parse_toml_args handles options starting with no- in the kontrol.toml file: it strips the no-, and sets the remaining option string to the negation of the argument provided. That's needed to accommodate options such as

  --break-on-calls      Store a node for every EVM call made.
  --no-break-on-calls   Do not store a node for every EVM call made (default).

But prevents no-stack-checks and other similar args from being parsed correctly.

@anvacaru anvacaru self-assigned this Oct 15, 2024
@PetarMax
Copy link
Contributor

We should note somewhere that Pi2-related usage of Kontrol should not use --no-stack-changes.

@palinatolmach palinatolmach changed the title add no stack changes to toml file add no-stack-checks to kontrol.toml file Oct 16, 2024
@palinatolmach palinatolmach self-assigned this Oct 16, 2024
src/kontrol/options.py Outdated Show resolved Hide resolved
@anvacaru anvacaru merged commit 1bc7712 into master Oct 16, 2024
12 checks passed
@anvacaru anvacaru deleted the default-prove-otps branch October 16, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants