-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for expectRevert(bytes4)
#519
Conversation
…REASON` with `OUT` by comparing the last 32 bytes where the signature is hold.
There are at least two tests that are skipped because we didn't have support for this cheatcode. Can you remove them from the
|
…everification/kontrol into tolga/expectrevert-bytes4-support
They have been added now. |
…everification/kontrol into tolga/expectrevert-bytes4-support
When |
…everification/kontrol into tolga/expectrevert-bytes4-support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with some formatting comments.
Co-authored-by: Andrei Văcaru <[email protected]>
Co-authored-by: Andrei Văcaru <[email protected]>
Resolves #466
This PR contains
expectRevert(bytes4)
selector in cheatcode support