New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Split without CSubst #4617

Merged

Stevengre merged 16 commits into develop from create-split-by-nodes

Sep 9, 2024

Contributor

Stevengre commented Sep 2, 2024

generate CSubst from the targets for Split
fix a bug in CSubst.apply.

Stevengre requested review from PetarMax, tothtamas28, ehildenb and anvacaru

September 2, 2024 08:00

Stevengre self-assigned this

Stevengre commented

View reviewed changes

pyk/src/pyk/cterm/cterm.py Outdated Show resolved Hide resolved

Stevengre commented

View reviewed changes

pyk/src/pyk/kcfg/kcfg.py Show resolved Hide resolved

Stevengre commented

View reviewed changes

pyk/src/tests/unit/test_kcfg.py Outdated Show resolved Hide resolved

Contributor Author

Stevengre commented Sep 2, 2024

Given this, I feel that CSubst might not be necessary. Instead, we could extract them from the nodes, eliminating the need to store them separately.

This was referenced Sep 2, 2024

Create split by nodes alternative #4618

Closed

Node merging to reduce branching for CSE #4425

Open

Stevengre force-pushed the create-split-by-nodes branch from 310f500 to 5a5d068 Compare

September 4, 2024 07:44

Stevengre commented

View reviewed changes

pyk/src/pyk/cterm/cterm.py Show resolved Hide resolved

Stevengre commented

View reviewed changes

pyk/src/pyk/kcfg/kcfg.py Show resolved Hide resolved

Stevengre commented

View reviewed changes

pyk/src/tests/unit/test_kcfg.py Outdated Show resolved Hide resolved

Stevengre commented

View reviewed changes

pyk/src/tests/unit/test_kcfg.py Show resolved Hide resolved

Stevengre commented

View reviewed changes

pyk/src/tests/unit/test_cterm.py Show resolved Hide resolved

ehildenb reviewed

View reviewed changes

pyk/src/pyk/kcfg/kcfg.py Outdated Show resolved Hide resolved

ehildenb reviewed

View reviewed changes

pyk/src/tests/unit/utils.py Outdated Show resolved Hide resolved

ehildenb mentioned this pull request

Mergeable heuristic in KCFGSemantics for merging node #4612

Closed

ehildenb reviewed

View reviewed changes

pyk/src/tests/unit/test_kcfg.py Show resolved Hide resolved

ehildenb reviewed

View reviewed changes

pyk/src/tests/unit/test_kcfg.py Outdated Show resolved Hide resolved

Stevengre mentioned this pull request

Feature merge node #4628

Merged

ehildenb approved these changes

View reviewed changes

ehildenb reviewed

View reviewed changes

pyk/src/pyk/cterm/cterm.py Outdated Show resolved Hide resolved

Stevengre added 5 commits

September 9, 2024 08:54


          create split from source to targets without csubst

4526bab


          add test

7d2eaa1


          fix apply doesn't allow a CTerm with constraints

40a307b


          combine the constraints for CSubst.apply

ccfc40f


          pass test

5b51ba0

Stevengre added 11 commits

September 9, 2024 08:58


          simplify the implementation

ca72beb


          [to delete] move untils into utils.py as #4621

a75f8e3


          unit-test for csubst apply


          test create_split_by_nodes

c605696


          refactor the until for tests


          add some comments for test cases; add a semantics-correct version of …

a77ac82

…split creating test case.


          fix make check

08ed2fa


          extract the match function

79ce02e


          better performance

d6059d1


          modify according to comments

65fc671


          udpate test

fb07b5d

Stevengre force-pushed the create-split-by-nodes branch from bc096e5 to fb07b5d Compare

September 9, 2024 00:59

Stevengre merged commit 15cbf88 into develop

17 checks passed

Stevengre deleted the create-split-by-nodes branch

September 9, 2024 02:34

ehildenb mentioned this pull request

Merge node #4541

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet