emit cell attribute into kore definition #4385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this affects some Pyk tests that reference the attribute subsystem; let me know if you want a hand from @tothtamas28 or me to sort those out. |
Here I think: k/pyk/src/pyk/konvert/_module_to_kore.py Line 726 in ff05627 |
added 2 commits
May 24, 2024 12:07
This test seems to fail intermittently due to some kind of nondeterminism in the haskell backend. It has failed on this PR for spurious reasons, and has failed similarly in the past. I believe it ought to be deleted since its incremental value individually is tiny
|
69fcd40: this seems to be another instance of runtimeverification/haskell-backend#3761. |
Scott-Guest
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
cellattribute back to the KORE definition in order to allow downstream usage in Pi Squared.