Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test workflow #30

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Add test workflow #30

merged 3 commits into from
Nov 12, 2024

Conversation

tothtamas28
Copy link
Contributor

@tothtamas28 tothtamas28 commented Nov 9, 2024 •
edited
Loading

Related: #1

  • Add smoke tests
  • Add test workflow

@tothtamas28 tothtamas28 self-assigned this Nov 9, 2024
@tothtamas28 tothtamas28 force-pushed the ci-tests branch 6 times, most recently from a52b33b to 36662f9 Compare November 9, 2024 16:59
Base automatically changed from kdist to master November 11, 2024 09:37
@tothtamas28 tothtamas28 marked this pull request as ready for review November 11, 2024 09:50
jberthold
jberthold approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@jberthold jberthold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
We could use the package/Dockerfile in CI, too, but it's hopefully not too much work to maintain a second one for CI

@tothtamas28 tothtamas28 merged commit dae8048 into master Nov 12, 2024
3 checks passed
@tothtamas28 tothtamas28 deleted the ci-tests branch November 12, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jberthold jberthold jberthold approved these changes

@ehildenb ehildenb Awaiting requested review from ehildenb

Assignees

@tothtamas28 tothtamas28

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tothtamas28 @jberthold