Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add wrappers for UpdateRegistryAuth and UpdateRegistryAuth. #355

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

pconstr
Copy link
Contributor

@pconstr pconstr commented Sep 21, 2024

adds wrappers for:

  • UpdateRegistryAuth (runpod.update_container_registry_auth)
  • DeleteRegistryAuth (runpod.delete_container_registry_auth)

and tests similar to what exists for generate_container_registry_auth

should address #317

tried it on my account, seems to work

@pconstr
Copy link
Contributor Author

pconstr commented Sep 24, 2024

Is there anything I can do to help here? Is doesn't look like these failures are related to the changed in the PR but maybe I missed something?

Copy link
Contributor

@galen-runpod galen-runpod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests were not your issue. Thanks for posting this, @pconstr !

@galen-runpod galen-runpod merged commit ca2bc00 into runpod:main Sep 25, 2024
3 of 8 checks passed
@pconstr
Copy link
Contributor Author

pconstr commented Sep 25, 2024

thanks for merge @galen-runpod . looking forward to seeing this in PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants