Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: refactor platform specific GHA CI #471

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

austinvazquez
Copy link
Member

Issue #, if available:

Description of changes:
This change refactors the GitHub Actions CI to split macOS and Windows verification such that macOS tests run only when its files change and vice-versa for Windows. The benefit is reduced contention for runners when pushing platform pull requests for Windows and macOS.

Testing done:

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This change refactors existing CI into platform specific CI so macOS
tests do not run on Windows-only changes and vice-versa.

Signed-off-by: Austin Vazquez <[email protected]>
@austinvazquez austinvazquez marked this pull request as ready for review December 25, 2024 04:26
@austinvazquez
Copy link
Member Author

No pushback, let me pull this in. Happy to iterate on it more if required.

@austinvazquez austinvazquez merged commit 016abfe into runfinch:main Dec 27, 2024
13 checks passed
@austinvazquez austinvazquez deleted the refactor-github-actions-ci branch December 27, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants