-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/merge rev219 #10
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e9edf59
This reverts commit 89ddebf
This also simplifies the redwoods overlay by just rendering logs, which removes the need for axe tracking
Jagex updated these steps to explicitly mention that they cannot be completed with Extracts
Co-authored-by: Max Weber <[email protected]>
Co-authored-by: burkeg <[email protected]> Co-authored-by: geheur <[email protected]>
This is most commonly encountered when players are assigned a Tzhaar task, but elect to upgrade it to a Jad or Zuk task. When this happens, the SLAYER_TASK_SIZE and SLAYER_TASK_CREATURE varps are set when starting the assignment dialog, and are later changed after opting in to the task change. The plugin had code which would preserve the previous initial amount (as of 1dbf432) but should no longer be needed as we can update it directly from var changes as opposed to tracking it ourselves.
This defaults to 0 not -1, and I don't see a way to use @Builder.Default with a constructor like this. Just assume 0 is invalid.
Co-authored-by: Erik <[email protected]>
Use top instead of first floor to avoid confusion between UK and US floor numbering
# Conflicts: # runelite-client/src/main/java/net/runelite/client/plugins/worldhopper/WorldSwitcherPanel.java
lost interface [kourend_favour] 246
[ci skip]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your PR title should match the following regex: ^([\w-/]+): \w+
!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.