Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPL-37 Allow custom bin path on gather facts false #398

Conversation

Jesus-Osuna-M
Copy link
Contributor

@Jesus-Osuna-M Jesus-Osuna-M commented Oct 24, 2024

Problem:
When customizing the “Ansible binaries path” and setting "Gather Facts" to "No," the Ansible resource model displays an error in the GUI.

Solution:
When "Gather Facts" is set to false, verify if the user has defined a file path for the Ansible binaries. If specified, include this path in the Ansible command used to retrieve the nodes.

Functional test:
https://github.com/rundeckpro/rundeckpro/pull/3991

@Jesus-Osuna-M Jesus-Osuna-M added this to the 5.8.0 milestone Oct 24, 2024
@Jesus-Osuna-M Jesus-Osuna-M changed the title allow custom bin path on gather facts false RPL-37 Allow custom bin path on gather facts false Oct 25, 2024
@Jesus-Osuna-M Jesus-Osuna-M marked this pull request as ready for review October 28, 2024 13:52
@ronaveva ronaveva self-requested a review October 29, 2024 12:53
Copy link
Contributor

@ronaveva ronaveva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jesus-Osuna-M Jesus-Osuna-M merged commit 9ed488a into main Nov 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants