chore: Add nil checks before returning wrapped error #5309
+77
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Add nil checks before returning wrapped errors.
why
Partially in prep for #5269, since if we return
fmt.Errorf("... : %w", err)
when err is nil, it won't, aserrors.Wrap(err, "...")
does in this situation, return nil.Additionally, I find that relying on
errors.Wrap(err, "...")
to returnnil
if err is nil a bit hard to read. It can also lead to subtle bugs like #5294 and #5312.I also put a few errors that were split between lines onto one line, which is more specifically in prep for #5269 (which I am writing a script to do replacements for mechanically).
tests
Just running unit tests.
references
Cleaning up code to make #5269 a bit simpler (though I think this change is worth doing on its own).