chore: Simplify use of the doublestar Match for ignore paths #5272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luke Massa <[email protected]>
lukemassa
requested review from
GenPage,
nitrocode and
X-Guardian
and removed request for
a team
dosubot
bot
added
the
refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Simplify use of the doublestar Match for ignore paths by using MatchUnvalidated.
why
We already explicitly validate all patterns when parsing the config, there's no reason to run Match(), which does additional validation and optionally returns an error.
I didn't quite understand how this package worked until a conversation with the maintainer (bmatcuk/doublestar#85), and now I think this is the correct approach.
tests
Running unit tests.
references