Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oci-genai] Option to pass auth_file_location, in-order to overwrite default config file location i.e. ~/.oci/config #17695

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

ashutoshSce
Copy link
Contributor

Description

Option to pass auth_file_location, if config file location is different form "~/.oci/config" where profile name configs present. This is not fixing any issues. Just added optional parameter called "auth_file_location", which internally supported by any OCI client including GenerativeAiInferenceClient.

Fixes # (issue)
Sometimes user have their config file other than "~/.oci/config" location. Currently there is no way to overwrite default config file location. On the other side GenerativeAiInferenceClient supports this internally. So we just have to pass this parameter before creating signer for GenerativeAiInferenceClient.

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Feb 1, 2025
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

@YouNeedCryDear YouNeedCryDear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you double check if format and lint is passed? @ashutoshSce

@ashutoshSce
Copy link
Contributor Author

ashutoshSce commented Feb 3, 2025

  • make format; make lint

@YouNeedCryDear
YES, It passed locally. I reran it. Please let me know, if I missed anything.

Screenshot 2025-02-04 at 1 07 30 AM Screenshot 2025-02-04 at 1 08 13 AM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 4, 2025
@logan-markewich logan-markewich enabled auto-merge (squash) February 4, 2025 15:03
@logan-markewich logan-markewich merged commit 659f9fa into run-llama:main Feb 4, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants