-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat notion reader add db content #17393
base: main
Are you sure you want to change the base?
Feat notion reader add db content #17393
Conversation
if this is likely to get merged just let me know |
@HenryRoutson if it works, it'll get merged -- net new features are nice :) |
Thanks! Just a heads up i am still working on it. |
Converting to draft since its still in progress (afaik) |
ok! All done now. |
Description
unfinished currently, i am still working on this currently
putting this up to make sure no one does the same thing
and for feedback
working on fixing a number of bugs including
And adding features
And most importantly
improved code quality,
with logic related to pagination and requests becoming more encapsulated
Fixes # (issue)
Version Bump?
Did I bump the version in the
pyproject.toml
file of the package I am updating? (Except for thellama-index-core
package)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.
i can add unit tests in future,
but for now i am using a large notion database as a realistic testing environment
Suggested Checklist:
make format; make lint
to appease the lint gods