nvidia-input #589
Merged
nvidia-input #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -7,7 +7,7 @@ The following document explains how to authenticate with Run:ai APIs. | |||
| Run:ai APIs are accessed using _bearer tokens_. A token can be obtained in several ways: | |||
|
|
|||
| * When logging into the Run:ai user interface, you enter an email and password (or authenticated via single sign-on) which are used to obtain a token. | |||
| * When using the Run:ai command-line, you use a Kubernetes profile and are authenticated by pre-running `runai login` (or oc login with OpenShift). The command attachs a token to the profile and allows you access to Run:ai functionality. | |||
| * When using the Run:ai command-line, you use a Kubernetes profile and are authenticated by pre-running `runai login` (or oc login with OpenShift). The command attaches a token to the profile and allows you access to Run:ai functionality. | |||
There was a problem hiding this comment.
[markdownlint] reported by reviewdog 🐶
MD013/line-length Line length [Expected: 80; Actual: 238]
| url = "https://" + COMPANY_URL + "/auth/realms/" + \ | ||
| COMPANY_REALM + "/protocol/openid-connect/token" | ||
|
|
||
| payload = 'grant_type=client_credentials&scope=openid&response_type=id_token&client_id=' + \ |
There was a problem hiding this comment.
[markdownlint] reported by reviewdog 🐶
MD013/line-length Line length [Expected: 80; Actual: 100]
| j = json.loads(response.text) | ||
| return j["access_token"] | ||
| else: | ||
| print(json.dumps(json.loads(response.text), sort_keys=True, indent=4, separators=(",", ": "))) |
There was a problem hiding this comment.
[markdownlint] reported by reviewdog 🐶
MD013/line-length Line length [Expected: 80; Actual: 106]
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
| @@ -7,7 +7,7 @@ The following document explains how to authenticate with Run:ai APIs. | |||
| Run:ai APIs are accessed using _bearer tokens_. A token can be obtained in several ways: | |||
|
|
|||
| * When logging into the Run:ai user interface, you enter an email and password (or authenticated via single sign-on) which are used to obtain a token. | |||
| * When using the Run:ai command-line, you use a Kubernetes profile and are authenticated by pre-running `runai login` (or oc login with OpenShift). The command attachs a token to the profile and allows you access to Run:ai functionality. | |||
| * When using the Run:ai command-line, you use a Kubernetes profile and are authenticated by pre-running `runai login` (or oc login with OpenShift). The command attaches a token to the profile and allows you access to Run:ai functionality. | |||
There was a problem hiding this comment.
📝 [vale] reported by reviewdog 🐶
[Microsoft.Passive] 'are authenticated' looks like passive voice.
| @@ -7,7 +7,7 @@ The following document explains how to authenticate with Run:ai APIs. | |||
| Run:ai APIs are accessed using _bearer tokens_. A token can be obtained in several ways: | |||
|
|
|||
| * When logging into the Run:ai user interface, you enter an email and password (or authenticated via single sign-on) which are used to obtain a token. | |||
| * When using the Run:ai command-line, you use a Kubernetes profile and are authenticated by pre-running `runai login` (or oc login with OpenShift). The command attachs a token to the profile and allows you access to Run:ai functionality. | |||
| * When using the Run:ai command-line, you use a Kubernetes profile and are authenticated by pre-running `runai login` (or oc login with OpenShift). The command attaches a token to the profile and allows you access to Run:ai functionality. | |||
There was a problem hiding this comment.
🚫 [vale] reported by reviewdog 🐶
[Vale.Spelling] Did you really mean 'oc'?
| @@ -7,7 +7,7 @@ The following document explains how to authenticate with Run:ai APIs. | |||
| Run:ai APIs are accessed using _bearer tokens_. A token can be obtained in several ways: | |||
|
|
|||
| * When logging into the Run:ai user interface, you enter an email and password (or authenticated via single sign-on) which are used to obtain a token. | |||
| * When using the Run:ai command-line, you use a Kubernetes profile and are authenticated by pre-running `runai login` (or oc login with OpenShift). The command attachs a token to the profile and allows you access to Run:ai functionality. | |||
| * When using the Run:ai command-line, you use a Kubernetes profile and are authenticated by pre-running `runai login` (or oc login with OpenShift). The command attaches a token to the profile and allows you access to Run:ai functionality. | |||
There was a problem hiding this comment.
📝 [vale] reported by reviewdog 🐶
[Microsoft.Vocab] Verify your use of 'allows' with the A-Z word list.
| print(json.dumps(json.loads(response.text), sort_keys=True, indent=4, separators=(",", ": "))) | ||
| return | ||
| import requests | ||
| import json |
There was a problem hiding this comment.
🚫 [vale] reported by reviewdog 🐶
[Vale.Spelling] Did you really mean 'json'?
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jasonnovichRunAI
added a commit
to jasonnovichRunAI/docs
that referenced
this pull request
Dec 17, 2023
jasonnovichRunAI
added a commit
that referenced
this pull request
Dec 17, 2023
Merge pull request #589 from run-ai/auth-python-revamp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.