Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.message-box added to qrcode.css to handle the messages properly. It will fix the the Incorrect display of messages on multiple lines #12 issue #306

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

.message-box added to qrcode.css to handle the messages properly. It will fix the the Incorrect display of messages on multiple lines #12 issue #306

wants to merge 1 commit into from

Conversation

Manazd
Copy link

@Manazd Manazd commented Jul 12, 2023 •
edited
Loading

".message-box" added to qrcode.css to handle the messages properly.
#12

@rugk rugk linked an issue Jul 18, 2023 that may be closed by this pull request
Incorrect display of messages on multiple lines #12
Open
@rugk
Copy link
Owner

rugk commented Jul 18, 2023

Hi @Manazd,
first of all, thanks for your first contribution to this project! 🎉 👍 🏅
I hope you'll like this project and enjoy hacking on it… 😃

BTW you can (automatically) let issues close when a PR is merged by adding some "magic" text to your PR body. (Manually linked it now.)

rugk
rugk reviewed Jul 18, 2023
View reviewed changes
Copy link
Owner

@rugk rugk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR, however, as it affects all add-ons I guess it would likely be good to have that source code in https://github.com/TinyWebEx/CommonCss/blob/57cd712256ae06a424b550521aabfbd855cfb4e3/common.css#L51 directly.

Also, do you have some screenshots to show how it looks? For visual changes that is always appreciated to easily have an idea how sth. looks.

@rugk rugk mentioned this pull request Sep 23, 2023
Open
@rugk
Copy link
Owner

rugk commented Oct 31, 2024

@Manazd If you need any pointers/help or have questions, feel free to ask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rugk rugk rugk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect display of messages on multiple lines
2 participants
@Manazd @rugk