-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds proper styles, Solves Issue #12 #262
base: master
Are you sure you want to change the base?
Conversation
Hi @Fanksies, Your code and the solution looks very nice, thanks. I'll take a deeper look soon. BTW you can (automatically) let issues close when a PR is merged by adding some "magic" text to your PR body. (Manually linked it now.) And another BTW: You can also upload GIFs/images on GitHub via drag & drop. 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your solution looks nice, but I see one problem:
AFAIK this always displays the button on the next line… I'd better only want the button displayed on the next line, if it is needed/i.e. if the message text is long and spans two lines.
@@ -171,6 +171,20 @@ a:active { | |||
margin-top: 8px; | |||
} | |||
|
|||
#messageContrast { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm #messageContrast
is only one case where this might happen.
It would be best if the solution were message-agnostic, i.e. somehow integrate it into .message-box
.
Thanks for the tips and the feedback, I sincerely appreciate them as they help me learn a lot in the process of contributing to open source projects. |
@Fanksies By the way… did you by chance found a solution or even just an idea here on how to solve this? |
I noticed too late that someone else had already attempted to fix this issue before, however I noticed that the issue was still open and decided to give it a shot.
Here's a preview of how it looks in GIF form
https://i.imgur.com/PE9Eqjs.gif
Let me know what you think.