Skip to content

Support click events on movie clips containing text fields #9995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 11, 2023

Conversation

jayrlsw
Copy link
Contributor

@jayrlsw jayrlsw commented Mar 11, 2023

Remove code that prevents click events from working on text fields within movie clips

@Aaron1011
Copy link
Member

We should test that the SWFs that originally required this are still working (I suspect they needed mouseEnabled/mouseChildren to be implemented) : #8744

@jayrlsw
Copy link
Contributor Author

jayrlsw commented Mar 11, 2023

We should test that the SWFs that originally required this are still working (I suspect they needed mouseEnabled/mouseChildren to be implemented) : #8744

@Aaron1011 I have gone through all of the SWFs mentioned in that issue. I can confirm that the problems are still resolved after this change.

@Lord-McSweeney
Copy link
Collaborator

As far as I know, the code that this PR removes was a hacky solution to fix some games that used mouseChildren, which was not yet implemented.

@Aaron1011 Aaron1011 enabled auto-merge (squash) March 11, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants