avm1: Don't ignore mouse_pick on static text (fix #9274) #9292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are other changes in #8744 in |
|
Not sure, wasn't needed for this to work, so I wanted to keep the changes minimal. |
|
Second commit will be removed following Discord discussion. |
danielhjacobs
changed the title
|
Can we add mouse pick tests for avm1 and avm2? |
|
I have not really messed with adding tests before and I'm not going to be able to do much more work on this PR until Thursday. If someone wants to push to the branch to add tests before then I don't have an issue with that as I allow edits by maintainers. |
danielhjacobs
force-pushed
the
fix_avm1_hittest_regression
branch
2 times, most recently
from
8414440 to
40a8cc2
Compare
danielhjacobs
changed the title
Dinnerbone
force-pushed
the
fix_avm1_hittest_regression
branch
from
551feb3 to
524e447
Compare
danielhjacobs
force-pushed
the
fix_avm1_hittest_regression
branch
2 times, most recently
from
aaf4853 to
4d716d9
Compare
Dinnerbone
force-pushed
the
fix_avm1_hittest_regression
branch
from
4d716d9 to
065f1fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.