avm2: Fix classes of objects created by newactivation and newcatch #20023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lord-McSweeney
added
A-avm2
Lord-McSweeney
force-pushed
the
avm2-correct-classes
branch
2 times, most recently
from
8a4a681 to
e0d4c3a
Compare
Lord-McSweeney
force-pushed
the
avm2-correct-classes
branch
2 times, most recently
from
d1bd0ec to
e5b9db6
Compare
adrian17
approved these changes
Apr 14, 2025
| @@ -215,8 +215,7 @@ pub enum Op<'gc> { | |||
| num_args: u32, | |||
| }, | |||
| NewCatch { | |||
| #[collect(require_static)] | |||
| index: Index<Exception>, | |||
There was a problem hiding this comment.
Personally I still like Index/u32 in ops where we know it's gonna be u32 :/ But not blocking the change either.
Lord-McSweeney
force-pushed
the
avm2-correct-classes
branch
from
e5b9db6 to
05c37bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.