text: Calculate character positions during relayout #18259
+49
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
added
text
Calculate character positions during relayout and store them in char_end_pos.
Use char_end_pos for calculating character bounds instead of evaluating the font each time.
This parameter is not needed anymore as character positions are calculated during relayout and the font doesn't have to be evaluated.
kjarosh
force-pushed
the
char-bounds-refactor
branch
from
220c7d7
to
436a445
Compare
Dinnerbone
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor simplifies existing code and makes it easier to write code related to character positions (evaluating a font each time is not needed anymore).