avm2: Support AIR application arguments #17609
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhjacobs
added
A-avm2
Dinnerbone
requested changes
Oct 7, 2024
| @@ -1,6 +1,7 @@ | |||
| network-settings = Paramètres réseau | |||
| player-settings = Paramètres du lecteur | |||
| movie-parameters = Paramètres de l'animation | |||
| air-arguments = Arguments de l'application AIR | |||
There was a problem hiding this comment.
FYI this will be deleted, these files are auto generated - you need to provide the translation on crowdin after the PR lands
| } | ||
| }); | ||
|
|
||
| Grid::new("open-file-params") |
There was a problem hiding this comment.
This ID needs to be unique
| @@ -337,6 +337,10 @@ impl OpenDialog { | |||
| self.movie_parameters(locale, ui); | |||
| }); | |||
|
|
|||
| ui.collapsing(text(locale, "air-arguments"), |ui| { | |||
There was a problem hiding this comment.
Can we only show this if the player type is air?
| @@ -667,6 +667,13 @@ export interface BaseLoadOptions { | |||
| * This allows you to emulate Adobe AIR or Adobe Flash Player. | |||
| */ | |||
| playerRuntime?: PlayerRuntime; | |||
|
|
|||
| /** | |||
| * Arguments variables to pass to the AIR application. | |||
There was a problem hiding this comment.
Suggested change
| * Arguments variables to pass to the AIR application. | |
| * Arguments to make available to the content through AIR's `NativeApplication.arguments`. This is only applicable if `playerRuntime` is `"air"`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #17299