Skip to content

text: Allow selecting text by dragging #16418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2024

Conversation

kjarosh
Copy link
Member

@kjarosh kjarosh commented May 22, 2024

This PR allows selecting text by pressing and dragging the mouse.

Related to #1891, #14996.

@kjarosh kjarosh force-pushed the edittext-drag-select branch 4 times, most recently from dcb0c42 to 439dae8 Compare May 22, 2024 18:40
@kjarosh kjarosh force-pushed the edittext-drag-select branch from 439dae8 to da5df4e Compare May 22, 2024 20:32
@kjarosh kjarosh marked this pull request as ready for review May 22, 2024 20:34
@danielhjacobs danielhjacobs added text Issues relating to text rendering/input waiting-on-review Waiting on review from a Ruffle team member labels May 23, 2024
@adrian17 adrian17 added waiting-on-author Waiting on the PR author to make the requested changes and removed waiting-on-review Waiting on review from a Ruffle team member labels May 24, 2024
@kjarosh kjarosh force-pushed the edittext-drag-select branch 2 times, most recently from 12609bd to 813ba0c Compare May 24, 2024 23:28
kjarosh added 2 commits May 26, 2024 12:27
This patch allows selecting text by pressing and dragging the mouse.
This test verifies that text in ExitText may be selected by dragging.
@adrian17 adrian17 force-pushed the edittext-drag-select branch from 813ba0c to 1b575b8 Compare May 26, 2024 10:27
@adrian17 adrian17 enabled auto-merge (rebase) May 26, 2024 10:28
@adrian17 adrian17 merged commit f195b5b into ruffle-rs:master May 26, 2024
17 checks passed
@kjarosh kjarosh deleted the edittext-drag-select branch May 26, 2024 10:46
@danielhjacobs danielhjacobs removed the waiting-on-author Waiting on the PR author to make the requested changes label May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
newsworthy text Issues relating to text rendering/input
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants