avm1: Cache ConstantPools for constant pools with more than 1000 entries #11980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lord-McSweeney
force-pushed
the
avm1-constant-pool-cache
branch
from
9d05e2f to
c66cfd4
Compare
moulins
reviewed
Jul 11, 2023
| @@ -27,6 +28,8 @@ pub struct Avm1<'gc> { | |||
| /// don't close over the constant pool they were defined with. | |||
| constant_pool: Gc<'gc, Vec<Value<'gc>>>, | |||
|
|
|||
| constant_pool_cache: HashMap<SwfPosition, Gc<'gc, Vec<Value<'gc>>>>, | |||
There was a problem hiding this comment.
If SWFs are repeatedly loaded then unloaded, this will cause a memory leak; this should probably be a weak_table::WeakKeyHashMap instead.
|
Why limit the caching to >1000 entries constant pools? I don't think always caching has any extra performance cost. |
Dinnerbone
added
the
waiting-on-author
danielhjacobs
added
A-avm1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes Tiny Battle (see #9785 (comment)) play at a reasonable speed after #11957. The game was using a constant pool with >18000 entries, which got re-interned in Ruffle every time the DoAction tag was iterated over.