Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default value for "Open Links" on the desktop app to "Ask" #17432

Open
Tiagoquix opened this issue Aug 9, 2024 · 2 comments · May be fixed by #18233
Open

Change default value for "Open Links" on the desktop app to "Ask" #17432

Tiagoquix opened this issue Aug 9, 2024 · 2 comments · May be fixed by #18233
Labels
A-desktop Area: Desktop Application enhancement New feature or request

Comments

@Tiagoquix
Copy link

Tiagoquix commented Aug 9, 2024 •
edited
Loading

Hello there.

Currently, "Open Links" on desktop has "Allow" as the default value.
I want to suggest to change it to "Ask" for two reasons:

  1. Security: you maybe wouldn't want to accesss a random link from 10 years ago and expose your IP address and other info to that website.
  2. Annoyance: sometimes I click on Flash elements that I have no idea that they are links. A confirmation in this case would be nice.

Also, "Open Links" option does not follow the pattern of having a checkbox to be able to modify the default value.
image

Not sure if making "Upgrade HTTP to HTTPS" enabled by default would be a good idea, but since Ruffle runs 100% locally on the Desktop (AFAIK) then it wouldn't be necessary, but would be cool nonetheless.

For the "Open Links" request, I believe changing "allow" to "ask" here would be sufficient.

Thanks in advance for your attention.
@n0samu n0samu added enhancement New feature or request A-desktop Area: Desktop Application labels Aug 9, 2024
@Lord-McSweeney Lord-McSweeney added A-web Area: Web & Extensions and removed A-web Area: Web & Extensions labels Aug 12, 2024
oadq added a commit to oadq/ruffle that referenced this issue Aug 28, 2024
@oadq
desktop: Change default value of Open Links to "Ask" (close ruffle-rs…
f2779db 
…#17432)

Change the defualt value of the "Open Links" setting from "Allow" to
"Ask". Having the default value of "Allow" may raise security concerns.
More details are in issue ruffle-rs#17432, which this commit solves.
oadq added a commit to oadq/ruffle that referenced this issue Aug 28, 2024
@oadq
desktop: Change default value of Open Links to "Ask" (close ruffle-rs…
15fc117 
…#17432)

Change the default value of the "Open Links" setting from "Allow" to
"Ask". Having the default value of "Allow" may raise security concerns.
More details are in issue ruffle-rs#17432, which this commit solves.
@oadq oadq mentioned this issue Aug 28, 2024
Open
@Korne127
Copy link
Contributor

When I introduced that feature (in #10625), there was a discussion on which value to use as the default
The consensus in the end was that it's okay to change it to Ask, but that we should then add a "Save this preference" checkbox so users don't get the prompt each time. I planned on doing that, but other things got in the way and then I forgot.
That was mostly about the web version though, but I think we should keep it consistent, and if we resolve this, change the option and add such a checkbox in both desktop and web.

@Tiagoquix
Copy link
Author

Tiagoquix commented Aug 28, 2024 •
edited
Loading

What could be done is do what I said (change it to "Ask" by default and add a checkbox to be consistent), and then add a new preference to control the default state of that setting to Ruffle user preferences (which get saved to ~/.config/ruffle/preferences.toml).

@kjarosh kjarosh mentioned this issue Aug 28, 2024
Merged
@kjarosh kjarosh linked a pull request Oct 10, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-desktop Area: Desktop Application enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

desktop: Move open URLs mode from launch options to preferences kjarosh/ruffle
4 participants
@Tiagoquix @Korne127 @n0samu @Lord-McSweeney