Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stable releases #308

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

kjarosh
Copy link
Member

@kjarosh kjarosh commented Jul 29, 2024

This PR adds "Stable Releases" section to downloads (if there are any) and replaces the default download links with the latest stable version (or the latest nightly if there's no stable). By default 3 last minor, and 2 last major releases are shown. "Compatibility" still uses nightly for measuring progress.

This PR may be tested by switching the repo in config to kjarosh/ruffle (there are some test releases).

Copy link
Contributor

@Dinnerbone Dinnerbone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I wonder why it had a random reformat... do we not auto format in this repo? 🤔

@kjarosh
Copy link
Member Author

kjarosh commented Jul 30, 2024

Hmmm... Running prettier . --write gives me 14 more changed files, so I guess formatting code is only a suggestion in this repo 😄

@danielhjacobs
Copy link
Collaborator

Fun fact, back when we used Jekyll, we had a small setup for stable releases, but it was removed with the switch to React:

{% if full_release.size > 0 %}
{% include releases.html releases=full_release limit=5 %}
{% endif %}

@danielhjacobs
Copy link
Collaborator

That setup was "5 last stable releases", no separation of major/minor.

@kjarosh
Copy link
Member Author

kjarosh commented Aug 5, 2024

Fixed searching for stable releases. Currently we have to traverse all releases to find out there's no stable releases (which takes around 15s, 80 releases per page, ~15 pages).

Also changed maxMajor to 1 in order not to traverse all releases when we have only one major version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants