Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vault, namespace, serviceAccount, external db, virtualService, and SSL certificate #49

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

maetolay
Copy link

@maetolay maetolay commented Apr 15, 2022

Description of the change

Adding support customizable features for the list below

  • Support injecting secret from Hashicorp Vault secret manager https://www.vaultproject.io
  • Support deploying in a different namespace and create the namespace from deployment
  • Support adding a service account name instead of using "default"
  • Support connecting to external PostgreSQL DB instead of in-cluster DB (for data persistence issues to avoid data loss when we need to destroy the deployment)
  • Support using Istio as an external gateway and adding virtual service to accept the connection
  • Support SSL certification using letsencrypt

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant