chore: adjust shopify upgrade to v2 #3924
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3924/test-report.html |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3924 +/- ##
========================================
Coverage 90.48% 90.49%
========================================
Files 615 617 +2
Lines 32359 32389 +30
Branches 7687 7692 +5
========================================
+ Hits 29281 29310 +29
- Misses 2822 2855 +33
+ Partials 256 224 -32 ☔ View full report in Codecov by Sentry. |
koladilip
previously approved these changes
Dec 10, 2024
|
koladilip
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this PR?
upgradedToSourceTransformV2infeatures.tsupgradedToSourceTransformV2nowWhat is the related Linear task?
Resolves INT-2899
Please explain the objectives of your changes below
To upgrade sources which are dependent on
query_parametersto V2 while maintaining fallback code incase of major errorsAny changes to existing capabilities/behaviour, mention the reason & what are the changes ?
Component test cases for sources run twice with 2 different feature.ts
upgradedToSourceTransformV2values.Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
In case of both shopify and adjust input specification conversion is going to happen twice.
Example case:
Shopify gets v1 request (with upgradedToSourceTransformV2 = true and rudder-server is not upgraded yet) - rare case
v1 request is converted to v2 spec first and shopifyv2 implementation internally coverts v2 to v1 and uses the same v1 code.
This will be a temporary performance concern until we are happy with the stability of the deployment.
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.