Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean deprecated files #3904

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

utsabc
Copy link
Member

@utsabc utsabc commented Nov 21, 2024

What are the changes introduced in this PR?

This PR aims to remove legacy router code for file upload

What is the related Linear task?

Resolves INT-1181

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@utsabc utsabc requested review from a team and sivashanmukh as code owners November 21, 2024 17:55
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.72%. Comparing base (0965f30) to head (37f8f19).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3904      +/-   ##
===========================================
+ Coverage    90.48%   90.72%   +0.23%     
===========================================
  Files          615      617       +2     
  Lines        32359    32407      +48     
  Branches      7687     7694       +7     
===========================================
+ Hits         29281    29402     +121     
+ Misses        2822     2781      -41     
+ Partials       256      224      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@utsabc utsabc added DO NOT MERGE Don't merge this PR without having discussion DO NOT TOUCH labels Nov 28, 2024
@devops-github-rudderstack
Copy link
Contributor

This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Don't merge this PR without having discussion DO NOT TOUCH
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants