Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reduce the error report sample events #5371

Merged
merged 16 commits into from
Dec 23, 2024

Conversation

koladilip
Copy link
Contributor

@koladilip koladilip commented Dec 12, 2024

Description

To reduce the load on the rudder server database, we are reducing the number of sample events collected.

Refactored some utils to reduce both metrics and error reporters.

Linear Ticket

https://linear.app/rudderstack/issue/INT-2974/%5Bchore%5D-collect-less-sample-events-from-errors-table#comment-926c8972
Resolves INT-2974

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 80.18018% with 22 lines in your changes missing coverage. Please review.

Project coverage is 74.83%. Comparing base (b417005) to head (83a53c5).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
enterprise/reporting/error_reporting.go 61.76% 11 Missing and 2 partials ⚠️
enterprise/reporting/utils.go 91.04% 6 Missing ⚠️
enterprise/reporting/reporting.go 60.00% 2 Missing ⚠️
...nterprise/reporting/event_sampler/event_sampler.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5371      +/-   ##
==========================================
+ Coverage   74.71%   74.83%   +0.11%     
==========================================
  Files         437      438       +1     
  Lines       61263    61296      +33     
==========================================
+ Hits        45775    45869      +94     
+ Misses      12946    12887      -59     
+ Partials     2542     2540       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vamsikrishnakandi vamsikrishnakandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @satishrudderstack can you please take a look

@koladilip koladilip enabled auto-merge (squash) December 23, 2024 12:46
@koladilip koladilip merged commit 989310c into master Dec 23, 2024
56 checks passed
@koladilip koladilip deleted the refactor/reduce-sample-events-in-error-reports branch December 23, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants